Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-19.0] Release of v19.0.4 #15882

Merged
merged 4 commits into from
May 8, 2024
Merged

[release-19.0] Release of v19.0.4 #15882

merged 4 commits into from
May 8, 2024

Conversation

systay
Copy link
Collaborator

@systay systay commented May 8, 2024

Includes the release notes and release commit for the v19.0.4 release. Once this PR is merged, we will be able to tag v19.0.4 on the merge commit.

systay added 3 commits May 8, 2024 12:26
@systay systay added Component: General Changes throughout the code base Do Not Merge Type: Release labels May 8, 2024
@systay systay mentioned this pull request May 8, 2024
Closed
25 tasks
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented May 8, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels May 8, 2024
@github-actions github-actions bot added this to the v19.0.4 milestone May 8, 2024
@systay systay removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels May 8, 2024
@codecov Codecov
Copy link

codecov bot commented May 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.44%. Comparing base (d438adf) to head (fc6b5a7).

Additional details and impacted files 
@@               Coverage Diff                @@
##           release-19.0   #15882      +/-   ##
================================================
- Coverage         67.45%   67.44%   -0.01%     
================================================
  Files              1560     1560              
  Lines            192812   192812              
================================================
- Hits             130052   130037      -15     
- Misses            62760    62775      +15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@systay
empty commit to trigger ci
fc6b5a7 
Signed-off-by: Andres Taylor <[email protected]>
@systay systay merged commit 2c56724 into release-19.0 May 8, 2024
198 of 199 checks passed
@systay systay deleted the release-19.0-create-release-10 branch May 8, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@shlomi-noach shlomi-noach shlomi-noach approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@ajm188 ajm188 Awaiting requested review from ajm188 ajm188 is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

Assignees
No one assigned
Labels
Component: General Changes throughout the code base Type: Release
Projects
None yet
Milestone
v19.0.4
Development

Successfully merging this pull request may close these issues.
3 participants
@systay @shlomi-noach @harshit-gangal